Skip to content

docs: retain Chinese READMEs and bilingual PR titles / 保留中文 README 和中英双语 PR 标题 - #3885

Merged
functionstackx merged 2 commits into
mainfrom
docs/retain-chinese-readmes-bilingual-pr-titles
Oct 9, 2026
Merged

functionstackx merged 2 commits into
mainfrom
docs/retain-chinese-readmes-bilingual-pr-titles

Conversation

@functionstackx

@functionstackx functionstackx commented Oct 9, 2026 •

Copy link
Copy Markdown
Collaborator

Remove Chinese documentation translations other than READMEs to reduce duplicate documentation maintenance. Retain all five existing README_zh.md files and keep PR titles in English and Simplified Chinese.

Put PR titles MUST MUST MUST HAVE CHINESE in a callout below the title and introduction in AGENTS.md. Update documentation policy and the Claude review prompt so agents do not recreate deleted translations, remove obsolete language switchers and the deleted file's CODEOWNERS entry, and point Chinese README links to the retained English guides.

This removes 17 translated documents. Benchmark code, recipes, performance history, and existing bilingual requirements for GitHub descriptions, comments, and commit bodies are unchanged.

AI model disclosure
  • Model/version: GPT-6 Astra Ultrafast.
  • Role: repository inspection, documentation and policy edits, local consistency checks, and PR preparation.
PR checklist and change type

Type of Change

  • Bug fix
  • New feature
  • Configuration change
  • Documentation update
  • Other (please describe)

Checklist

  • I have completed the AI model disclosure and kept it current
  • I have tested my changes locally
  • I have updated documentation if necessary
  • For every change that can affect benchmark performance and every recipe addition or modification, I have appended a new entry to the physical end of inferencex-e2e/perf-changelog.yaml and have not edited historical entries
  • If this PR can affect benchmark performance or adds or modifies a recipe, it carries exactly one primary sweep label (a maintainer applies it on fork PRs): full-sweep-fail-fast (recommended), full-sweep-enabled, or non-canary-full-sweep-enabled. Optional modifiers all-evals, evals-only, and agentx-fast require a primary label; the last two block reuse while applied.
  • Before merging via reuse, an authorized maintainer (OWNER/MEMBER/COLLABORATOR) has commented /use <run_id> (or the legacy /reuse-sweep-run) on this PR. Do this only once there is a final full sweep that is all green with evals passing, since after this comment the primary sweep label will no longer automatically kick off new sweeps. Remove and re-add the primary sweep label to force a new sweep.

The performance changelog, sweep-label, and reuse items do not apply to this documentation and agent-policy change.

中文

删除 README 以外的中文文档译本,减少重复维护。保留全部五个现有的 README_zh.md 文件,PR 标题继续同时使用英文和简体中文。

在 AGENTS.md 标题和简介下方以引用块突出显示 PR titles MUST MUST MUST HAVE CHINESE。更新文档维护规则和 Claude 审阅提示,防止 agent 重新创建已删除的译本;移除失效的语言切换链接和已删除文件对应的 CODEOWNERS 条目,并将中文 README 中的相关链接指向保留的英文文档。

共删除 17 个中文文档译本。基准测试代码、recipe、性能历史记录,以及 GitHub 描述、评论和 commit 正文的现有双语要求均保持不变。此 PR 仅修改文档与 agent 规则,不涉及性能变更,因此无需性能 changelog、sweep 标签或运行结果复用。

AI 模型:GPT-6 Astra Ultrafast,负责仓库检查、文档与规则修改、本地一致性检查和 PR 准备。

中文:删除 README 以外的中文文档译本,保留中英双语 PR 标题,在 AGENTS.md 顶部强调中文标题要求,并修正文档链接和维护规则。
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Thanks for the contribution!

  • Review: If this PR changes files owned by someone other than a repository admin or @SemiAnalysisAI/core, ask one eligible CODEOWNER to complete the latest PR_REVIEW_CHECKLIST.md before contacting a core maintainer on Slack. Follow the template exactly, including As a PR reviewer and CODEOWNER, I have reviewed this and have, so sign-off verification triggers.
  • PR verification: Sweeps run only when the PR appends an inferencex-e2e/perf-changelog.yaml entry and carries exactly one primary label: full-sweep-fail-fast (strongly recommended; canary plus per-matrix fail-fast), full-sweep-enabled (canary; matrix jobs continue after a failure), or non-canary-full-sweep-enabled (no canary or fail-fast). The modifiers all-evals, evals-only, and agentx-fast require a primary label. On fork PRs, a maintainer applies the label. See sweep labels and reuse.
  • After merging: PR authors must ensure all GitHub Actions jobs pass. Transient failures often pass on rerun; see how to rerun failed jobs.
中文

感谢你的贡献!

  • **审阅:**如果 PR 修改的文件归属于仓库管理员及 @SemiAnalysisAI/core 之外的 CODEOWNER,请先联系一位有资格的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,再通过 Slack 联系核心维护者。必须严格遵循模板,并保留 As a PR reviewer and CODEOWNER, I have reviewed this and have,才能触发签核验证。
  • **PR 验证:**只有当 PR 在 inferencex-e2e/perf-changelog.yaml 末尾追加了条目,并且恰好带有一个主标签时,才会运行扫描:full-sweep-fail-fast(强烈推荐;canary 加逐矩阵 fail-fast)、full-sweep-enabled(有 canary;矩阵任务在失败后继续运行)或 non-canary-full-sweep-enabled(无 canary,也无 fail-fast)。修饰标签 all-evals、evals-only 和 agentx-fast 必须与主标签一起使用。fork PR 的标签由维护者添加。参见扫描标签与复用。
  • **合并后:**PR 作者必须确保所有 GitHub Actions 任务通过。临时性失败通常可以通过重新运行恢复;参见重新运行失败任务的说明。

中文:将 PR 标题中文要求移至 AGENTS.md 简介下方的引用块,保留原文。

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this PR and didn't find any bugs — the automated review ran clean. Because it changes repository-wide documentation policy, touches CODEOWNERS and files owned by maintainers other than the PR author (e.g. operatorx/CI.md under @ hbarclay, inferencex-e2e/docs/MODELS.md under @ ankur-singh/@ chunfangamd), and deletes 17 translated docs plus adds a new PR-title policy, a human look would still be worthwhile.

What was reviewed: the removal of 17 _zh.md files and their language-switcher links across READMEs/docs for dangling references (none found — all remaining links point to existing English pages or the 5 retained README_zh.md files); the CODEOWNERS entry removal for the deleted MODELS_zh.md; the AGENTS.md/CONTRIBUTING.md policy text for internal consistency with the new "READMEs-only" Chinese-translation rule; and the claude.yml workflow prompt update reflecting the same policy.

Extended reasoning...

Large documentation-policy PR (40 files, -3782/+34 lines) deleting 17 Chinese translated docs, updating AGENTS.md/CONTRIBUTING.md policy text, CODEOWNERS, and the claude.yml review-bot prompt; no code/security-sensitive paths touched. Checked all changed and several unchanged docs for dangling links to the deleted _zh.md files and found the switcher removals and link rewrites consistent and mechanical. Deferred rather than approved because the change touches CODEOWNERS-protected paths owned by maintainers other than the PR author (operatorx, MODELS.md) and encodes a repo-wide policy decision (Chinese-doc retention limited to READMEs, new mandatory bilingual PR title line in AGENTS.md) that a human owner should sign off on.

This review covers commit 5356f33, which is no longer the latest commit on this pull request; later commits are not covered by it.

@functionstackx
functionstackx merged commit f43144d into main Oct 9, 2026
7 checks passed
@functionstackx
functionstackx deleted the docs/retain-chinese-readmes-bilingual-pr-titles branch October 9, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant