Repository navigation
Conversation
|
Thanks for the contribution!
中文感谢你的贡献!
|
|
Generally most InferenceX submissions don't need to add changes to the infx package. On the off chance they do, generally the diff is small. Please prompt your agent to clean your PR to keep your diff to only necessary & minimal changes too. We have an increased code quality bar for changes to the infx package. 中文大多数 InferenceX 提交通常不需要修改 infx 包。即使确实需要,改动通常也很小。请让你的 agent 清理 PR,使改动只包含必要且最小的内容。infx 包的改动有更高的代码质量要求。 |
There was a problem hiding this comment.
I reviewed this PR and found no bugs. Beyond the bug-hunter's findings, I checked whether a perf-changelog.yaml entry was required for the removed llm-d recipes and ruled it out — AGENTS.md states deletions are tracked via git history and existing changelog entries, with the mandatory-entry rule applying to additions/modifications, not removals. I also confirmed no residual llmd/LlmdRequest references remain anywhere in infx/.
Extended reasoning...
This is a pure deletion PR (2 insertions / 2158 deletions across 21 files) removing the standalone llm-d launch path (driver, policy route, request model, benchmark scripts, recipes, tests) per the author's stated rationale that llm-d now runs through srt-slurm's own frontend.type. No security-sensitive surface is touched. I verified no dangling references to the removed code remain and that the one plausible gap (missing perf-changelog entry) is explicitly not required by AGENTS.md for deletions.
Signed-off-by: Cam Quilici <cjquilici@gmail.com>
7f2a1e6 to
06e74aa
Compare
Remove the
llmd-vllmlaunch path that #3613 added: theLLMDdriver,LlmdRequest, and its policy route, plusbenchmarks/multi_node/llm-d,benchmarks/multi_node/llm-d-recipes,benchmarks/llm-d, thellmd-vllmruntime settings, and the gb200-nv model override for it. No master config usesllmd-vllm. llm-d runs through srt-slurm'sfrontend.type: llm-d(NVIDIA/srt-slurm#588), which the submodule includes as of v2.49.0 (#3882).