Missing tolerations for keda patched jobs #2911

[anwaramoon]

User description

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Fixes #2911

Motivation and Context

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• I have read the contributing document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

---

PR Type

Bug fix

---

Description

• Add missing tolerations support for KEDA patched jobs

• Enable pod scheduling on tainted nodes for cleanup operations

---

Diagram Walkthrough

flowchart LR
  A["KEDA Jobs"] --> B["Add Tolerations"]
  B --> C["Pod Scheduling"]
  C --> D["Tainted Nodes"]

Loading

File Walkthrough

Relevant files

Bug fix

delete-keda-objects-job.yaml Add tolerations to delete job                                                        charts/selenium-grid/templates/patch-keda/delete-keda-objects-job.yaml Add tolerations configuration block for delete job Enable pod scheduling on nodes with taints +3/-0      patch-keda-objects-job.yaml Add tolerations to patch job                                                          charts/selenium-grid/templates/patch-keda/patch-keda-objects-job.yaml Add tolerations configuration block for patch job Enable pod scheduling on nodes with taints +3/-0

---

[CLAassistant]

All committers have signed the CLA.

[qodo-merge-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Indentation Issue The tolerations block is incorrectly indented and placed inside the containers section instead of at the pod spec level. This will cause YAML parsing errors and prevent the tolerations from being applied correctly. {{- with $.Values.autoscaling.patchObjectFinalizers.tolerations }} tolerations : {{ toYaml . | nindent 12 }} {{- end }} Indentation Issue The tolerations block is incorrectly indented and placed inside the containers section instead of at the pod spec level. This will cause YAML parsing errors and prevent the tolerations from being applied correctly. {{- with $.Values.autoscaling.patchObjectFinalizers.tolerations }} tolerations : {{ toYaml . | nindent 12 }} {{- end }}

[qodo-merge-pro]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	✅ Fix tolerations placement in pod spec Suggestion Impact: The suggestion partially impacted the commit - the indentation was changed from 12 to 8 spaces as suggested, but the tolerations block was not moved to the correct pod spec level position code diff: - tolerations : {{ toYaml . | nindent 12 }} + tolerations : {{ toYaml . | nindent 8 }} The tolerations field should be at the pod spec level, not under the container. Move it to be a sibling of containers and volumes for proper Kubernetes pod scheduling. charts/selenium-grid/templates/patch-keda/delete-keda-objects-job.yaml [39-41] -{{- with $.Values.autoscaling.patchObjectFinalizers.tolerations }} - tolerations : {{ toYaml . | nindent 12 }} +{{- with $.Values.autoscaling.patchObjectFinalizers.tolerations }} + tolerations: {{ toYaml . | nindent 8 }} {{- end }} [Suggestion processed] Suggestion importance[1-10]: 9 __ Why: The suggestion correctly identifies that the tolerations block is incorrectly placed within the container definition, which would cause the Kubernetes job to fail, and provides the correct fix.	High
Update

[VietND96]

@anwaramoon, thank you!