fix: Summit cold start from checkpoint deadlock#131
Open
HenryMBaldwin wants to merge 6 commits intoh/staking-and-joiningfrom
Open
fix: Summit cold start from checkpoint deadlock#131HenryMBaldwin wants to merge 6 commits intoh/staking-and-joiningfrom
HenryMBaldwin wants to merge 6 commits intoh/staking-and-joiningfrom
Conversation
…forkchoice if syncing is required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When starting a wiped node from a summit checkpoint where the execution client has clean state, summit deadlocks (irrecoverably AFAIK) because it treats
SYNCINGfrom the execution client as a failure.Solution
This is solved with an initial syncing phase, prompted by sending an initial forkchoice update to the execution client to set the sync target, and polling until it's done syncing.
Notably, if the execution client doesn't have any peers or is unable to sync for any reason, this is also effectively stalls the node. IMO this is still a strict improvement over previous behavior.