fix: nodes would still try and build ontop a bad eth block#125
Merged
daltoncoder merged 3 commits intomainfrom Feb 13, 2026
Merged
fix: nodes would still try and build ontop a bad eth block#125daltoncoder merged 3 commits intomainfrom
daltoncoder merged 3 commits intomainfrom
Conversation
daltoncoder
force-pushed
the
d/debug-bad-eth-block
branch
2 times, most recently
from
c969864 to
5ca0f21
Compare
daltoncoder
force-pushed
the
d/debug-bad-eth-block
branch
from
5ca0f21 to
40e456e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem was legacy code overwriting forkchoice.head_block_hash in application crate. We get a valid forkchoice from the finalizer that we need to use without any modifications. Also added a feature flag "bad-blocks" that will replace the engine client with one that makes an invalid payload every 4 blocks to help with debugging and testing things like this later.
cargo run --bin testnet --features bad-blockswill start a testnet with an invalid ethereum block in the chain every 4 blocks and will still move forward just fine