Skip to content

chore: update rpc tp use epoch as key for finalized header #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthias-wright merged 1 commit into from
Feb 10, 2026
Merged

chore: update rpc tp use epoch as key for finalized header #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions finalizer/src/ingress.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,9 @@ impl<S: Scheme<B::Commitment>, B: ConsensusBlock + Committable> FinalizerMailbox
maybe_checkpoint
}

pub async fn get_finalized_header(&mut self, height: u64) -> Option<FinalizedHeader<S>> {
pub async fn get_finalized_header(&mut self, epoch: u64) -> Option<FinalizedHeader<S>> {
let (response, rx) = oneshot::channel();
let request = ConsensusStateRequest::GetFinalizedHeader(height);
let request = ConsensusStateRequest::GetFinalizedHeader(epoch);

let _ = self
.sender
Expand Down
8 changes: 4 additions & 4 deletions rpc/src/server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,11 @@ impl SummitApiServer for SummitRpcServer {
return Err(RpcError::CheckpointNotFound.into());
};

// try to get the finalized header for the last block
// try to get the finalized header for this epoch
let maybe_header = self
.finalizer_mailbox
.clone()
.get_finalized_header(last_block.height())
.get_finalized_header(epoch)
.await;

let Some(header) = maybe_header else {
Expand All @@ -89,11 +89,11 @@ impl SummitApiServer for SummitRpcServer {
return Err(RpcError::CheckpointNotFound.into());
};

// try to get the finalized header for the last block
// try to get the finalized header for this epoch
let maybe_header = self
.finalizer_mailbox
.clone()
.get_finalized_header(last_block.height())
.get_finalized_header(epoch)
.await;

let Some(header) = maybe_header else {
Expand Down
4 changes: 2 additions & 2 deletions types/src/consensus_state_query.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,9 +138,9 @@ impl<S: Scheme> ConsensusStateQuery<S> {
balance
}

pub async fn get_finalized_header(&self, height: u64) -> Option<FinalizedHeader<S>> {
pub async fn get_finalized_header(&self, epoch: u64) -> Option<FinalizedHeader<S>> {
let (tx, rx) = oneshot::channel();
let req = ConsensusStateRequest::GetFinalizedHeader(height);
let req = ConsensusStateRequest::GetFinalizedHeader(epoch);
let _ = self.sender.clone().send((req, tx)).await;

let res = rx
Expand Down