fix: use expected_is_private instead of hardcoded true in empty-root path#31
Open
drappi-ai wants to merge 2 commits intozellic-audit-feb-2026from
Open
fix: use expected_is_private instead of hardcoded true in empty-root path#31drappi-ai wants to merge 2 commits intozellic-audit-feb-2026from
drappi-ai wants to merge 2 commits intozellic-audit-feb-2026from
Conversation
Demonstrates that verify_proof's empty-root fast path hardcodes expected_private: true instead of using the caller-provided expected_is_private parameter (issue #209).
…path In verify_proof's empty-root fast path, the ValueMismatch error was hardcoding expected_private: true instead of reflecting the caller's expected_is_private parameter. Fixes SeismicSystems/internal#209.
drappi-ai
force-pushed
the
cdai__fix-209-hardcoded-private
branch
from
90a2131 to
6b611da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verify_proof's empty-root fast path hardcodedexpected_private: truein theValueMismatcherror instead of using the caller-providedexpected_is_privateexpected_private: true→expected_private: expected_is_privateAddresses SeismicSystems/internal#209.
Test plan
empty_root_value_mismatch_uses_expected_privateregression test