fix: reject empty proofs with trailing nodes#30
Open
drappi-ai wants to merge 2 commits intozellic-audit-feb-2026from
Open
fix: reject empty proofs with trailing nodes#30drappi-ai wants to merge 2 commits intozellic-audit-feb-2026from
drappi-ai wants to merge 2 commits intozellic-audit-feb-2026from
Conversation
Add a test demonstrating that verify_proof incorrectly accepts proofs with trailing nodes after an empty node (e.g., [EMPTY, junk...]) when root == EMPTY_ROOT_HASH and expected_value == None. This test currently fails, confirming the bug described in SeismicSystems/internal#207.
After peeking to determine an empty proof case, consume the first element and verify no remaining elements exist. If trailing nodes are present, return a new TrailingProofNodes error. This prevents proofs like [EMPTY, junk...] from being accepted as valid exclusion proofs. Fixes SeismicSystems/internal#207
drappi-ai
force-pushed
the
cdai__fix-207-lenient-empty-proof
branch
from
747ea56 to
91db654
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EMPTY_STRING_CODE) were accepted even with trailing junk nodesTrailingProofNodeserror variant; after accepting the empty node, verify no remaining elements existAddresses SeismicSystems/internal#207.
Test plan
empty_proof_with_trailing_nodes_is_rejectedregression test