feat: compiler warning for using shielded values in branching conditions + prevent shielded types as inputs for abi.encode#95
Open
matthias-wright wants to merge 5 commits intoseismicfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes two changes to prevent leakage of private information.
The motivation for 1 are examples like the following. In this if condition
the gas usage can give information about the shielded value
shieldedBalance.Tests were added to verify this behavior.
The full warning looks like this:
The motivation for 2 is the fact that
abi.encodeetc all returnbytes. Sincebytesis not shielded, it would leak information about the shielded input.