Skip to content

ci(semantics): pull in seismic; use seismic branch in ssol#203

Merged
cdrappi merged 5 commits intoveridise-audit-feb-2026from
cdai__ci-seismic-solidity
Mar 6, 2026
Merged

ci(semantics): pull in seismic; use seismic branch in ssol#203
cdrappi merged 5 commits intoveridise-audit-feb-2026from
cdai__ci-seismic-solidity

Conversation

@drappi-ai
Copy link
Copy Markdown
Contributor

Summary

  • Removes the pinned test--new-storage-opcode-semantics branch checkout for seismic-solidity in the semantic tests CI job
  • The upstream fixes have been merged (seismic-solidity#130), so we can now use the default seismic branch

Test plan

  • CI semantic tests pass against the default seismic-solidity branch

@drappi-ai drappi-ai requested a review from cdrappi as a code owner March 5, 2026 23:19
@cdrappi cdrappi changed the title ci: clone seismic-solidity default branch in semantic tests ci: in semantic tests runner, go back to using the seismic branch Mar 5, 2026
cdrappi added 3 commits March 5, 2026 18:40
Adds a CLI flag to skip semantic tests that require via-IR compilation
(compileViaYul: true). Use this when the solc binary does not support
--via-ir.
Adds a CLI flag to force solc's via-IR compilation pipeline for
semantic tests. Tests that explicitly opt out (compileViaYul: false)
are skipped rather than forced through the incompatible pipeline.
The seismic solc compiler will require --unsafe-via-ir whenever --via-ir
is used, making it explicit that via-IR compilation is experimental.

This commit adds the corresponding --unsafe-via-ir flag to the semantic
tests runner. Key behaviors:

  - --unsafe-via-ir enables via-IR compilation by passing both --via-ir
    and --unsafe-via-ir to the compiler
  - --via-ir now requires --unsafe-via-ir (clap validation)
  - Tests with compileViaYul: true are auto-skipped when --unsafe-via-ir
    is not set, since the compiler would reject them
  - --unsafe-via-ir conflicts with --skip-via-ir
  - compile_solidity() guards against --via-ir without --unsafe-via-ir

Additionally, all test skips are now tracked by reason and printed as a
grouped summary at the end of a run:

    Skipped 63 test file(s):
        42 - via-IR required (use --unsafe-via-ir to enable)
        15 - unsupported: multi-source files (==== Source:)
         3 - unsupported: allowNonExistingFunctions
         2 - unsupported: revertStrings: debug
         1 - EOF required (use --eof to enable)

The full decision matrix is documented in --help on the --via-ir flag.
@drappi-ai drappi-ai force-pushed the cdai__ci-seismic-solidity branch from 970e6cd to dd6e3de Compare March 6, 2026 14:28
The storage opcode semantic test fixes have been merged upstream
(seismic-solidity#130), so we no longer need to pin the
test--new-storage-opcode-semantics branch.
@drappi-ai drappi-ai force-pushed the cdai__ci-seismic-solidity branch from dd6e3de to 6f23ed0 Compare March 6, 2026 14:46
@cdrappi cdrappi changed the title ci: in semantic tests runner, go back to using the seismic branch ci: pull in seismic; use seismic branch in ssol for semantics Mar 6, 2026
@cdrappi cdrappi changed the title ci: pull in seismic; use seismic branch in ssol for semantics ci(semantics): pull in seismic; use seismic branch in ssol for semantics Mar 6, 2026
@cdrappi cdrappi changed the title ci(semantics): pull in seismic; use seismic branch in ssol for semantics ci(semantics): pull in seismic; use seismic branch in ssol Mar 6, 2026
@cdrappi cdrappi merged commit 61fb9e5 into veridise-audit-feb-2026 Mar 6, 2026
6 checks passed
@cdrappi cdrappi deleted the cdai__ci-seismic-solidity branch March 6, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants