[DONT MERGE] feat(semantic tests): add --skip-via-ir and --via-ir flags#183
Merged
[DONT MERGE] feat(semantic tests): add --skip-via-ir and --via-ir flags#183
Conversation
Adds a CLI flag to skip semantic tests that require via-IR compilation (compileViaYul: true). Use this when the solc binary does not support --via-ir.
Adds a CLI flag to force solc's via-IR compilation pipeline for semantic tests. Tests that explicitly opt out (compileViaYul: false) are skipped rather than forced through the incompatible pipeline.
cdrappi
force-pushed
the
ci-via-ir-support
branch
from
f953543 to
7b0d29b
Compare
The seismic solc compiler will require --unsafe-via-ir whenever --via-ir
is used, making it explicit that via-IR compilation is experimental.
This commit adds the corresponding --unsafe-via-ir flag to the semantic
tests runner. Key behaviors:
- --unsafe-via-ir enables via-IR compilation by passing both --via-ir
and --unsafe-via-ir to the compiler
- --via-ir now requires --unsafe-via-ir (clap validation)
- Tests with compileViaYul: true are auto-skipped when --unsafe-via-ir
is not set, since the compiler would reject them
- --unsafe-via-ir conflicts with --skip-via-ir
- compile_solidity() guards against --via-ir without --unsafe-via-ir
Additionally, all test skips are now tracked by reason and printed as a
grouped summary at the end of a run:
Skipped 63 test file(s):
42 - via-IR required (use --unsafe-via-ir to enable)
15 - unsupported: multi-source files (==== Source:)
3 - unsupported: allowNonExistingFunctions
2 - unsupported: revertStrings: debug
1 - EOF required (use --eof to enable)
The full decision matrix is documented in --help on the --via-ir flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.