fix(storage): CLOAD shouldnt modify storage privacy bit#182
Open
samlaf wants to merge 1 commit intoveridise-audit-feb-2026from
Open
fix(storage): CLOAD shouldnt modify storage privacy bit#182samlaf wants to merge 1 commit intoveridise-audit-feb-2026from
samlaf wants to merge 1 commit intoveridise-audit-feb-2026from
Conversation
Fixes veridise-799: This issue affects newly created accounts where an uninitialized storage slot is accessed via CLOAD before any SSTORE occurs. In such cases, the slot becomes marked as private despite never being written to, causing subsequent public writes to fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes veridise-799.
This issue affects newly created accounts where an uninitialized storage slot is accessed via CLOAD before any SSTORE occurs. In such cases, the slot becomes marked as private despite never being written to, causing subsequent public writes to fail.
Future Steps
I'm keeping this PR minimal to only fix the issue finding, but I think we could/should refactor more aggressively and keep the journal layer completely agnostic to cload/sload semantics. See my draft PR for how this can be achieved. Feedback welcome!!