Skip to content

Trie: invalidate cache when private flag changes #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cdrappi wants to merge 2 commits into
base: stable
Choose a base branch
from
Open

Trie: invalidate cache when private flag changes #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7595e6b
invalidate cache when private flag changes
cdrappi Jul 28, 2025
7223cde
only update alloy-trie
cdrappi Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -762,7 +762,7 @@ alloy-sol-types = { git = "https://github.com/SeismicSystems/seismic-alloy-core.
alloy-sol-type-parser = { git = "https://github.com/SeismicSystems/seismic-alloy-core.git", rev = "bc4b5ed" }
alloy-dyn-abi = { git = "https://github.com/SeismicSystems/seismic-alloy-core.git", rev = "bc4b5ed" }

alloy-trie = { git = "https://github.com/SeismicSystems/seismic-trie.git", rev = "417644c" }
alloy-trie = { git = "https://github.com/SeismicSystems/seismic-trie.git", rev = "3f094397e43290c077b6faaa35cfccd31cd38191" }

# revm
revm = { git = "https://github.com/SeismicSystems/seismic-revm.git", rev = "e7fa9fab"}
Expand Down
9 changes: 8 additions & 1 deletion crates/trie/sparse/src/trie.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1512,7 +1512,14 @@ impl<P: BlindedProvider> RevealedSparseTrie<P> {
self.prefix_set.insert(path.clone());
let existing = self.values.insert(path.clone(), value);
if existing.is_some() {
// trie structure unchanged, return immediately
// Check if is_private flag changed and invalidate hash if so
if let Some(SparseNode::Leaf { is_private: ref mut existing_is_private, hash: ref mut existing_hash, .. }) =
self.nodes.values_mut().find(|node| matches!(node, SparseNode::Leaf { .. })) {
if *existing_is_private != is_private {
*existing_is_private = is_private;
*existing_hash = None; // Force hash recomputation
}
}
return Ok(());
}

Expand Down