rework enclave contract to better support multiple accepted measurements#166
Open
daltoncoder wants to merge 21 commits intoseismicfrom
Open
rework enclave contract to better support multiple accepted measurements#166daltoncoder wants to merge 21 commits intoseismicfrom
daltoncoder wants to merge 21 commits intoseismicfrom
Conversation
This reverts commit 5b15e5d.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I switched around UpgradeOperator.sol to be able to handle supporting multiple accepted TD measurements at one time. My main concern was with the previous way was it was hard to tell what was currently supported without knowing the hash of the measurements. And we had to create a new Struct everytime we needed to add pcr we cared about in the measurements.
Main Changes:
registrar_slotsandregistrar_valuesfield. The former is which pcr registrars we care about and the latter is the value, aligned by index. This will allow our different supported measurements to care about different pcr registrars which i think will be the case with our azure vs bare metal measurementsbytes32[] public acceptedTags;andbytes32[] public deprecatedTags;that make it easy to get all currently accepted measurements and previously deprecated measurementsStill Todo before this PR is ready:
Fix our previous rust based tests for the old version. Maybe able to remove them now that we have solidity unit tests but ill have to fix up our integration test script as it looks for the rust test binary to run.Ready