Feature/custom infinite quantum storage #164
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustAHuman-xD
requested changes
Nov 13, 2023
Collaborator
JustAHuman-xD
left a comment
JustAHuman-xD
left a comment
There was a problem hiding this comment.
most of these are style things so sefi or test feel free to weigh in or just simple mark as resolved regardless lol
src/main/java/io/github/sefiraat/networks/slimefun/network/NetworkQuantumStorage.java
Show resolved
Hide resolved
src/main/java/io/github/sefiraat/networks/slimefun/network/NetworkQuantumStorage.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/sefiraat/networks/slimefun/network/NetworkQuantumStorage.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/sefiraat/networks/slimefun/network/NetworkQuantumStorage.java
Show resolved
Hide resolved
src/main/java/io/github/sefiraat/networks/slimefun/network/NetworkQuantumStorage.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/sefiraat/networks/slimefun/network/NetworkQuantumStorage.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/sefiraat/networks/slimefun/network/NetworkQuantumStorage.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/sefiraat/networks/slimefun/network/NetworkQuantumStorage.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/sefiraat/networks/slimefun/network/NetworkQuantumStorage.java
Outdated
Show resolved
Hide resolved
Author
|
@JustAHuman-xD Thanks for your review and suggestions with regards to code style, I really appreciate it! I've made some changes and resolved those I think should have been initially in the PR and a few others I've added a bit more context for consideration by Sefi and yourself. |
Collaborator
|
@test137E29B No problem! |
LobbyTech-MC
pushed a commit
to LobbyTech-MC/Networks
that referenced
this pull request
Feb 13, 2025
Author
|
@Sefiraat any movement on this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability for top tier infinite quantum to have configurable maximum storage size between 1 and the previous maximum limit of Int max.
Doesn't allow more than the max into the quantum's storage.
Correctly shows in held item
Correctly sets custom limit when placed, if stored on the itemstack
Doesn't show up for the non infinite tier quantums