Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source sorting in topics pages #151

Merged
merged 3 commits into from
Feb 2, 2025
Merged

Source sorting in topics pages #151

merged 3 commits into from
Feb 2, 2025

Conversation

YishaiGlasner
Copy link
Contributor

The goal of this PR is bringing the sources in TopicPage to be ordered as they are in web.
Changes:

  1. Change 'order' object of topic sources (in api.js) as it's done on web (in sefaria.js).
  2. Change 'refSort' function to match what we do on web.

Also - some changes in Hebrew strings for gender sensetivity.

@yitzhakc yitzhakc merged commit 3ec904c into master Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yitzhakc yitzhakc yitzhakc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YishaiGlasner @yitzhakc