feat: Adding string_version_compare and version_compare functions #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding functions similar to GNU's strverscmp and versioncompare so that we can use them in other OS's that do not support these in their own libc. This version is not as fast as the GNU version, but it's pretty close. Signed-off-by: Tyler Erickson <[email protected]>
vonericsen
requested review from
sharma-nidhi and
shriya-deshmukh
and removed request for
AnkurDG
…s required to pass version_sort Adding some additional checks to auto-detect when to define the old signature versus the new Signed-off-by: Tyler Erickson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding functions similar to GNU's strverscmp and versioncompare so that we can use them in other OS's that do not support these in their own libc.
This version is not as fast as the GNU version, but it's pretty close.
Signed-off-by: Tyler Erickson [email protected]