Skip to content

fix: miscellaneous fixes to weapon/gear and their categories, levels, and stats#276

Merged
ScuffedNewt merged 5 commits intoScuffedNewt:extension/claymores-and-companionsfrom
perappu:extension-pr/claymores-and-companions
Mar 9, 2026
Merged

fix: miscellaneous fixes to weapon/gear and their categories, levels, and stats#276
ScuffedNewt merged 5 commits intoScuffedNewt:extension/claymores-and-companionsfrom
perappu:extension-pr/claymores-and-companions

Conversation

@perappu
Copy link
Copy Markdown

@perappu perappu commented Mar 9, 2026

Just a whole host of fixes I found (sorry it's all lumped into one PR/commit, I copied these over from a site I was working on, lol):

  • Gear description column being a string and not text
  • Use world._entry and not claymore._entry for gear and weapon categories to prevent 500 errors on create/edit pages and the encyclopedia
  • Fixed missing 'edit' value from various claymore._entry includes
  • Allow general stat to be updated without getting blocked by the base stat value check
  • Use the JS color picker for stat color
  • Proper pagination on the admin LevelController getLevels() function
  • Incorrect URL for stats on the encyclopedia sidebar
  • Incorrect highlighting for gear on the encyclopedia sidebar (fixed by making sure the beginning of the URL isn't shared, much like skills and weapons)
  • Added missing @include('js._tinymce_wysiwyg') for status, elements, skills, and skill categories

Does include a migration to fix the gear description column, so php artisan migrate will need to be run.

Thanks for your time!

Copy link
Copy Markdown
Owner

@ScuffedNewt ScuffedNewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good pr, thank you!

@ScuffedNewt ScuffedNewt merged commit 452443b into ScuffedNewt:extension/claymores-and-companions Mar 9, 2026
3 checks passed
@perappu perappu deleted the extension-pr/claymores-and-companions branch March 10, 2026 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants