Skip to content

Vc3d migration and cleanup - #361

Merged
stephenrparsons merged 20 commits into
mainfrom
vc3d-migration-and-cleanup
Sep 8, 2025
Merged

Vc3d migration and cleanup#361
stephenrparsons merged 20 commits into
mainfrom
vc3d-migration-and-cleanup

Conversation

@stephenrparsons

Copy link
Copy Markdown
Contributor

No description provided.

@stephenrparsons stephenrparsons self-assigned this Sep 5, 2025
@vercel

vercel Bot commented Sep 5, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
scrollprize-org Ignored Ignored Preview Sep 8, 2025 6:53pm

Comment thread volume-cartographer/README.md Outdated
Comment thread .github/workflows/vc3d_ci.yml Outdated
uses: docker/build-push-action@v6
with:
file: ubuntu-24.04-noble.Dockerfile
file: volume-cartographer/ubuntu-24.04-noble.Dockerfile

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please verify that the Dockerfile exists at the updated path volume-cartographer/ubuntu-24.04-noble.Dockerfile. This change adds the volume-cartographer/ prefix to the path, which should match the new repository structure after migration. If the file was moved but not renamed during this restructuring, the path may need adjustment.

Spotted by Diamond

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SuperOptimizer instead of changing this path I think it would make more sense to change the working directory of the workflow to ./volume-cartographer as is done e.g. here https://github.com/ScrollPrize/villa/blob/main/.github/workflows/deploy-vesuvius.yml

@github-advanced-security

Copy link
Copy Markdown

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@stephenrparsons
stephenrparsons merged commit 681abd5 into main Sep 8, 2025
5 checks passed
@stephenrparsons
stephenrparsons deleted the vc3d-migration-and-cleanup branch September 8, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants