Add exportMap #43
Open
Add exportMap #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiennou
force-pushed
the
feature/map-export
branch
2 times, most recently
from
6381baa to
2db6b99
Compare
AlinaNova21
requested changes
Mar 17, 2025
lib/services/importMap/utils.js
Outdated
| @@ -185,4 +231,7 @@ module.exports = (config) => { | |||
|
|
|||
| config.utils.importMapFile._help = | |||
| 'importMapFile(filePath) - import a map from a json file' | |||
|
|
|||
| config.utils.exportMap._help = | |||
| 'exportMapFile(filePath) - export the map to a json file' | |||
There was a problem hiding this comment.
This did not match the signature used above
| @@ -177,6 +220,9 @@ module.exports = (config) => { | |||
| const rooms = await getMapFromFile(filePath) | |||
| await loadRooms(config, filePath, rooms) | |||
| return logFinish() | |||
| }, | |||
| async exportMap () { | |||
There was a problem hiding this comment.
This signature doesn't match the help text
There was a problem hiding this comment.
Oh right, I took that out because it felt easier to just dump into the asset directory. I'll remove that.
tiennou
force-pushed
the
feature/map-export
branch
from
2db6b99 to
18271c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.