Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify release workflow to have tag/release version as required input #1861

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Modify release workflow to have tag/release version as required input #1861

wants to merge 8 commits into from

Conversation

nicomiguelino
Copy link
Contributor

No description provided.

@nicomiguelino nicomiguelino requested a review from a team as a code owner March 14, 2024 21:19
vpetersson
vpetersson requested changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@vpetersson vpetersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, tag should be the git tag for a release.

@nicomiguelino nicomiguelino changed the title Modify release workflow to have tag/release version as required … Modify release workflow to have tag/release version as required input Mar 14, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@nicomiguelino
Copy link
Contributor Author

@vpetersson,

Got it. The release step doesn't run successfully if no tags were specified.
For instance, in this CI run:

  • "Error: Error undefined: No tag found in ref or input!"
  • The release action works in such a way that if no tags were found, a new one will be created.

It can also be seen in this change that the tags property was removed. (See screenshot below for details).

image

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpetersson vpetersson vpetersson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Anthias
Status: Code Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicomiguelino @vpetersson