fix: repair bcos formula test block - #9
Conversation
|
Received, and queued for review — apologies for the silence up to now. This is a maintainer-side backlog rather than any verdict on your contribution. We I'm not going to give you a date I might miss. What I can tell you:
Thanks for your patience, and for the work. |
|
Reviewed and merging — sorry it sat 66 days, that's on us. Verified by reading the diff: this removes the |
|
Correction: I went to merge and it has conflicts — the formula drifted in the 66 days this sat. The change itself is still correct and approved; it just needs a rebase onto current |
Rebased onto main after Scottcjn#11 landed the Pathname#write fix; the three changes that Scottcjn#11 did not cover: - assert the formula's own version instead of a hard-coded "1.8.0" - drop the '|| true' masks on 'bcos --help' and 'bcos scan' so a failing command fails the test (verified at clawrtc 1.8.0: both exit 0, help prints "BCOS", scan prints "Trust Score") - trailing newline Signed-off-by: Scott <scottbphone12@gmail.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ad07321 to
9e5c81c
Compare
Summary
write_filecall in the BCOS formula test block withPathname#write|| truefrom test commands sobrew testdoes not mask failuresversion.to_sinstead of hard-coding1.8.0Scope
This only changes
Formula/bcos.rbtest-block behavior. It does not alter the tarball URL, SHA, install block, package source, or formula metadata.Validation
ruby -c Formula/bcos.rb-> Syntax OKgit diff --check -- Formula/bcos.rb-> passed (Windows line-ending warning only)I could not run
brew testin this Windows workspace because Homebrew is not installed here.AI assistance
Implemented with OpenAI Codex assistance after reading issue #8 and the current formula.