Add dependency security audit workflow#978
Open
CelebrityPunks wants to merge 1 commit intoScottcjn:mainfrom
Open
Add dependency security audit workflow#978CelebrityPunks wants to merge 1 commit intoScottcjn:mainfrom
CelebrityPunks wants to merge 1 commit intoScottcjn:mainfrom
Conversation
Introduces a GitHub Action that scans Python dependencies for known vulnerabilities using pip-audit and safety. Runs on dependency file changes, weekly on schedule, and on manual dispatch. Reports results to the job summary and uploads artifacts for review. Closes Scottcjn/rustchain-bounties#1605
|
Welcome to RustChain! Thanks for your first pull request. Before we review, please make sure:
Bounty tiers: Micro (1-10 RTC) | Standard (20-50) | Major (75-100) | Critical (100-150) A maintainer will review your PR soon. Thanks for contributing! |
Scottcjn
requested changes
Mar 15, 2026
Owner
Scottcjn
left a comment
There was a problem hiding this comment.
Good idea for a CI workflow, but a few issues to fix:
safety checkrequires an API key now for the commercial Safety DB. WithoutSAFETY_API_KEY, it will always fail (masked bycontinue-on-error: true). Either add a secret or remove the safety step.issues: writepermission is granted but never used (no step creates issues). Remove for least-privilege.- Confirm that
requirements.txtandrequirements-node.txtexist in the repo — if not, the job is a no-op.
Fix these and I will merge.
achievefibromyalgia-lgtm
approved these changes
Mar 15, 2026
achievefibromyalgia-lgtm
left a comment
There was a problem hiding this comment.
Code Review: #978 Dependency Security Audit
Overall: Essential security improvement!
Strengths:
- Uses pip-audit and safety for vulnerability scanning
- Good coverage (Python dependencies)
- Scheduled runs (weekly) + on-push triggers
Technical Quality:
- Clean workflow YAML
- Good security practices
Verdict: ✅ Approved - Important security addition!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dependency-audit.yml) that scans Python dependencies for known vulnerabilitiespip-auditandsafetyto check installed packages against vulnerability databasesrequirements.txtBounty
Closes Scottcjn/rustchain-bounties#1605
Test plan
workflow_dispatchto verify it runspip-auditandsafetyscan results appear in job summaryrequirements.txtchanges