Skip to content

[BOUNTY #16251] Fix install script — wrong paths + macOS crash, shellcheck-clean #8025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhaog100 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[BOUNTY #16251] Fix install script — wrong paths + macOS crash, shellcheck-clean #8025

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,8 @@ elif command -v sysctl &>/dev/null; then
else
CPU="$ARCH"
fi
# Sanitize CPU string for display (remove extra whitespace)
CPU=$(echo "$CPU" | tr -s ' ')
echo " CPU: $CPU"

# ─── Download Helpers ────────────────────────────────────────────────
Expand Down Expand Up @@ -218,9 +220,9 @@ echo -e "${GREEN}[2/6]${NC} Checking Python..."
PYTHON=""
for cmd in python3 python; do
if command -v $cmd &>/dev/null; then
ver=$($cmd --version 2>&1 | grep -oP '\d+\.\d+')
major=$(echo $ver | cut -d. -f1)
minor=$(echo $ver | cut -d. -f2)
ver=$($cmd --version 2>&1 | grep -o '[0-9]\+\.[0-9]\+' | head -1)
major=$(echo "$ver" | cut -d. -f1)
minor=$(echo "$ver" | cut -d. -f2)
if [ "$major" -ge 3 ] && [ "$minor" -ge 6 ]; then
PYTHON=$cmd
echo " Found: $cmd ($($cmd --version 2>&1))"
Expand All @@ -231,7 +233,11 @@ done

if [ -z "$PYTHON" ]; then
echo -e "${RED} Python 3.6+ required but not found.${NC}"
echo " Install with: sudo apt install python3 python3-pip"
if [ "$OS" = "Darwin" ]; then
echo " Install with: brew install python3"
else
echo " Install with: sudo apt install python3 python3-pip"
fi
exit 1
fi

Expand Down
Loading