fix(gpu-attest): tensor-core gate string-compares CC, dropping channel for CC>=10#8009
Open
Vyacheslav-Tomashevskiy wants to merge 1 commit into
Open
Conversation
…el for CC>=10
get_gpu_attestation_payload gated the Channel 8f tensor-core fingerprint on
fp.compute_capability >= "7.0", a lexical string comparison. compute_capability
is f"{major}.{minor}", so "10.0" >= "7.0" is False ('1' < '7') — the newest
tensor-core GPUs (Blackwell CC 10.0, RTX-50 CC 12.0) silently skipped the
channel while Volta..Hopper worked. Parse numerically via a small helper and
add a torch-free regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug
get_gpu_attestation_payload(node/gpu_attestation.py) gates the Channel 8f Tensor Core fingerprint on the GPU's compute capability:compute_capabilityis a string (GPUFingerprint.compute_capability: str, built asf"{major}.{minor}"— "7.0", "8.0", "9.0", "10.0", "12.0").>=on strings compares lexically, so:The check is meant to include Volta and newer (all of which have tensor cores). It instead silently drops the tensor-core channel for exactly the newest tensor-core GPUs — Blackwell data-center (CC 10.0) and consumer Blackwell / RTX-50 (CC 12.0) — while Volta..Hopper (7.0-9.x) pass. Those miners' attestation payloads are missing Channel 8f entirely.
The fix
Parse the value numerically via a small helper (so it's unit-testable without a GPU):
Test
Added
node/tests/test_gpu_tensor_core_cc_compare.py(torch-free —import torchin gpu_attestation is function-local): Volta..Hopper supported; CC 10.0 / 12.0 now supported (and asserts the old lexical compare returned False for them); pre-Volta and malformed values rejected without crashing. 4 pass.Verified against
upstream/main@ c6501de.RTC:
RTCd1554f0f35576faf01d386a6be1c947f560dd0b7