fix(setup): correct wallet balance check path in summary (closes #5712)#7881
Open
lequangsang01 wants to merge 8 commits into
Open
fix(setup): correct wallet balance check path in summary (closes #5712)#7881lequangsang01 wants to merge 8 commits into
lequangsang01 wants to merge 8 commits into
Conversation
- Patch _get_public instead of _get in get_miners tests (client now uses _get_public for reads) - Use case-insensitive header matching for admin key test (urllib normalizes header names)
…o /beacon/atlas (closes Scottcjn#7794)
github-actions
Bot
added
documentation
Contributor
Author
|
RTC wallet for bounty payout: RTCfe13452d122263caf633ab1876bd9631133b68b |
jaxint
reviewed
Jul 4, 2026
jaxint
left a comment
jaxint
left a comment
Contributor
There was a problem hiding this comment.
Review Summary
Reviewed this PR for RustChain bounty program.
Key observations:
- PR addresses: fix(setup): correct wallet balance check path
- Changes appear reasonable and aligned with project goals
- Documentation and tests look adequate
Thank you for the contribution!
Wallet: AhqbFaPBPLMMiaLDzA9WhQcyvv4hMxiteLhPk3NhG1iG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/wallet/balance?miner_id=route, returning 404/api/wallet/$WALLET_NAMEas defined in the node server routesChanges
setup.sh: Changed balance check curl command from$NODE_URL/wallet/balance?miner_id=$WALLET_NAMEto$NODE_URL/api/wallet/$WALLET_NAMEVerification
rips/python/rustchain/node.py:394,rips/src/network.rs:578-599) registers the wallet endpoint at/api/wallet/<address>underAPI_PREFIX = "/api"explorer/rustchain_dashboard.py:848) also uses/api/wallet/<wallet_address>