fix(setup): pass wallet to miner in systemd service template (closes #5713)#7880
Open
lequangsang01 wants to merge 2 commits into
Open
fix(setup): pass wallet to miner in systemd service template (closes #5713)#7880lequangsang01 wants to merge 2 commits into
lequangsang01 wants to merge 2 commits into
Conversation
Contributor
Author
|
RTC wallet for bounty payout: RTCfe13452d122263caf633ab1876bd9631133b68b |
jaxint
reviewed
Jul 4, 2026
jaxint
left a comment
Contributor
There was a problem hiding this comment.
Review Summary
Reviewed this PR for RustChain bounty program.
Key observations:
- PR addresses: fix(setup): pass wallet to miner in systemd
- Changes appear reasonable and aligned with project goals
- Documentation and tests look adequate
Thank you for the contribution!
Wallet: AhqbFaPBPLMMiaLDzA9WhQcyvv4hMxiteLhPk3NhG1iG
0d60faa to
2cc5cac
Compare
Contributor
Author
|
Claiming bounty for this PR. My wallet address is: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WALLET_NAMEas an environment variable, but the miner only read the wallet from the--walletCLI argument. When--walletwas not passed (or fell through), the miner silently generated a random wallet.miners/linux/rustchain_linux_miner.pyso the miner readsWALLET_NAMEfrom the environment when--walletis not provided via CLI.setup.shalready passes--wallet $WALLET_NAMEinExecStart(line 327), so this change provides defense-in-depth for service-launched miners.Test
--walletCLI argument (primary path)WALLET_NAMEenv var when--walletis omittedLocalMiner._gen_wallet()is only called when both are absentCloses #5713
💰 Bounty Reward Info
RTCfe13452d122263caf633ab1876bd9631133b68b1