fix(spv): reject oversized BloomFilter bitsets in from_hex (closes #6466)#7879
Open
lequangsang01 wants to merge 10 commits into
Open
fix(spv): reject oversized BloomFilter bitsets in from_hex (closes #6466)#7879lequangsang01 wants to merge 10 commits into
lequangsang01 wants to merge 10 commits into
Conversation
- Patch _get_public instead of _get in get_miners tests (client now uses _get_public for reads) - Use case-insensitive header matching for admin key test (urllib normalizes header names)
…o /beacon/atlas (closes Scottcjn#7794)
github-actions
Bot
added
documentation
Contributor
Author
|
RTC wallet for bounty payout: RTCfe13452d122263caf633ab1876bd9631133b68b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BloomFilter.from_hex()to validate the byte length of the hex input against the configuredsize_bits, not just the bit length of the decoded integerbit_length() > size_bits) only caught cases where the highest set bit exceeded the filter size, but allowed oversized hex strings with leading zeros to pass validation"00ff"withsize_bits=8)Changes
node/spv_client.py: Replacebit_length()check with byte-length validation usingexpected_bytes = (size_bits + 7) // 8node/tests/test_spv_client.py: Addtest_bloom_filter_rejects_oversized_hex_with_leading_zerosTest plan