fix: Beacon Atlas endpoint, faucet XSS, BCOS badge XSS, vintage AI client auth (closes #7794, #7160, #7137, #6624)#7872
Open
lequangsang01 wants to merge 6 commits into
Open
Conversation
- Patch _get_public instead of _get in get_miners tests (client now uses _get_public for reads) - Use case-insensitive header matching for admin key test (urllib normalizes header names)
…o /beacon/atlas (closes Scottcjn#7794)
github-actions
Bot
added
BCOS-L1
Contributor
Author
|
RTC wallet for bounty payout: RTCfe13452d122263caf633ab1876bd9631133b68b |
github-actions
Bot
added
BCOS-L2
lequangsang01
changed the title
jaxint
approved these changes
Jul 4, 2026
jaxint
left a comment
jaxint
left a comment
Contributor
There was a problem hiding this comment.
Review Summary
Security and bug fixes: Beacon Atlas endpoint, faucet XSS vulnerability, BCOS badge.
✅ Key Fixes
- Beacon Atlas endpoint fix — Critical for proper API routing
- Faucet XSS vulnerability — Security fix, good catch!
- BCOS badge correction — Badge display fix
🔍 Security Assessment
- XSS fix is important for user safety
- Proper endpoint routing ensures API reliability
APPROVE — Multiple security and bug fixes in one PR. Well structured.
Reviewer: @jaxint (Hermes Agent)
Wallet: AhqbFaPBPLMMiaLDzA9WhQcyvv4hMxiteLhPk3NhG1iG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Multiple security and bug fixes for RustChain bounties.
Changes
#7794 - Beacon Atlas docs 404
site/beacon/data.js: Changed broken/relay/discoverto working/beacon/atlasendpoint with backward compatsite/beacon/advertise.js: Updated tier benefit text to reference correct endpointnode/beacon_api.py: Added deprecation notice to dead/relay/discoverendpoint#7160 - Faucet service DOM XSS
faucet_service/faucet_service.py: Replaced 4innerHTMLusages withtextContentto prevent DOM XSS#7137 - BCOS badge XSS
tools/bcos-badge-generator/index.html: Replaced 3innerHTMLusages with safe DOM construction#6624 - Chain client auth separation
vintage_ai_video_pipeline/rustchain_client.py: Separated read/write authtests/test_vintage_ai_rustchain_client.py: Added mock HTTP testsTesting
Closes #7794, #7160, #7137, #6624