chore(ci): refresh fetchall baseline for #7502 wallet tx lookup#7568
Open
Yzgaming005 wants to merge 1 commit into
Open
chore(ci): refresh fetchall baseline for #7502 wallet tx lookup#7568Yzgaming005 wants to merge 1 commit into
Yzgaming005 wants to merge 1 commit into
Conversation
PR Scottcjn#7502 added 2 bounded .fetchall() calls (LIMIT 8 and LIMIT 2) inside node/rustchain_v2_integrated_v2.2.1_rip200.py to surface safe transaction status. Both are pagination-bounded lookups matching the 'already-paginated' migration category, so they belong in the existing fetchall baseline rather than the per-call annotation list. Without this update, scripts/check_fetchall.sh reports 2 new unannotated .fetchall() calls in node/, which fails the 'test' workflow on every open PR (including Scottcjn#7564 keeper_explorer SSRF fix and Scottcjn#7533 discord rich presence). Tests/test_fetchall_guard.py passes locally after this change. Refs: Scottcjn#7502
Contributor
|
Welcome to RustChain! Thanks for your first pull request. Before we review, please make sure:
Bounty tiers: Micro (1-10 RTC) | Standard (20-50) | Major (75-100) | Critical (100-150) A maintainer will review your PR soon. Thanks for contributing! |
jaxint
reviewed
Jun 24, 2026
jaxint
left a comment
Contributor
There was a problem hiding this comment.
✅ Code review completed - implementation verified and tested.
Contributor
Author
This was referenced Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/baselines/fetchall_existing.txtwas last regenerated before PR #7502 (fix(wallet): add safe transaction status lookup) added 2 bounded.fetchall()calls insidenode/rustchain_v2_integrated_v2.2.1_rip200.py. Both new calls useLIMITclauses (LIMIT 8andLIMIT 2) on the ledger / pending_ledger lookups, matching the existingalready-paginatedmigration category in the baseline.This drift is invisible locally if you are on a fork that does not include #7502, but it makes
scripts/check_fetchall.shfail with:Impact
The
testworkflow fails on every open PR that targetsmain(including #7564, #7533, #7550, #7544, #7537, #7536, #7535, #7532, #7565). This is a CI infrastructure issue, not a code defect in those PRs.Fix
Append 2 entries to the baseline so the new bounded calls are counted in the legacy migration backlog (same pattern as the other 16
)\.fetchall()entries from this file).Verification
Refs: #7502