Skip to content

chore(ci): refresh fetchall baseline for #7502 wallet tx lookup#7568

Open
Yzgaming005 wants to merge 1 commit into
Scottcjn:mainfrom
Yzgaming005:ci/fix-fetchall-baseline-7502
Open

chore(ci): refresh fetchall baseline for #7502 wallet tx lookup#7568
Yzgaming005 wants to merge 1 commit into
Scottcjn:mainfrom
Yzgaming005:ci/fix-fetchall-baseline-7502

Conversation

@Yzgaming005

Copy link
Copy Markdown
Contributor

Summary

scripts/baselines/fetchall_existing.txt was last regenerated before PR #7502 (fix(wallet): add safe transaction status lookup) added 2 bounded .fetchall() calls inside node/rustchain_v2_integrated_v2.2.1_rip200.py. Both new calls use LIMIT clauses (LIMIT 8 and LIMIT 2) on the ledger / pending_ledger lookups, matching the existing already-paginated migration category in the baseline.

This drift is invisible locally if you are on a fork that does not include #7502, but it makes scripts/check_fetchall.sh fail with:

ERROR: 2 new unannotated .fetchall() call(s) in node/.
New unannotated hits:
  node/rustchain_v2_integrated_v2.2.1_rip200.py:).fetchall()
  node/rustchain_v2_integrated_v2.2.1_rip200.py:).fetchall()

Impact

The test workflow fails on every open PR that targets main (including #7564, #7533, #7550, #7544, #7537, #7536, #7535, #7532, #7565). This is a CI infrastructure issue, not a code defect in those PRs.

Fix

Append 2 entries to the baseline so the new bounded calls are counted in the legacy migration backlog (same pattern as the other 16 )\.fetchall() entries from this file).

+node/rustchain_v2_integrated_v2.2.1_rip200.py:).fetchall()
+node/rustchain_v2_integrated_v2.2.1_rip200.py:).fetchall()

Verification

$ bash scripts/check_fetchall.sh
OK: no new unannotated .fetchall() calls in node/.
Legacy baseline count: 180 (issue #6627 migration backlog).

$ python3 -m pytest tests/test_fetchall_guard.py -v
tests/test_fetchall_guard.py::test_fetchall_guard_passes_current_baseline PASSED
tests/test_fetchall_guard.py::test_fetchall_guard_blocks_new_unannotated_call PASSED
tests/test_fetchall_guard.py::test_fetchall_guard_blocks_whitespace_before_call_parens PASSED
tests/test_fetchall_guard.py::test_fetchall_guard_allows_annotated_call PASSED
tests/test_fetchall_guard.py::test_fetchall_guard_fails_closed_when_required_tools_are_missing PASSED
tests/test_fetchall_guard.py::test_fetchall_guard_detects_stale_baseline_entries PASSED
6 passed

Refs: #7502

PR Scottcjn#7502 added 2 bounded .fetchall() calls (LIMIT 8 and LIMIT 2) inside
node/rustchain_v2_integrated_v2.2.1_rip200.py to surface safe transaction
status. Both are pagination-bounded lookups matching the 'already-paginated'
migration category, so they belong in the existing fetchall baseline rather
than the per-call annotation list.

Without this update, scripts/check_fetchall.sh reports 2 new unannotated
.fetchall() calls in node/, which fails the 'test' workflow on every open
PR (including Scottcjn#7564 keeper_explorer SSRF fix and Scottcjn#7533 discord rich presence).
Tests/test_fetchall_guard.py passes locally after this change.

Refs: Scottcjn#7502
@github-actions

Copy link
Copy Markdown
Contributor

Welcome to RustChain! Thanks for your first pull request.

Before we review, please make sure:

  • Non-doc PRs have a BCOS-L1 or BCOS-L2 label
  • Doc-only PRs are exempt from BCOS tier labels when they only touch docs/**, *.md, or common image/PDF files
  • New code files include an SPDX license header
  • You've tested your changes against the live node

Bounty tiers: Micro (1-10 RTC) | Standard (20-50) | Major (75-100) | Critical (100-150)

A maintainer will review your PR soon. Thanks for contributing!

@github-actions github-actions Bot added the size/XS PR: 1-10 lines label Jun 24, 2026

@jaxint jaxint left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Code reviewed - implementation verified. Per bounty #71.

@jaxint jaxint left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Code review completed - implementation verified and tested.

@Yzgaming005

Copy link
Copy Markdown
Contributor Author

🔗 Bumping for maintainer attention — this PR is the CI blocker for 8 of my other open PRs, all of which fail on test_fetchall_guard_passes_current_baseline until this baseline refresh lands:

All 8 PRs are otherwise green — the fetchall guard is the only red. Would appreciate a merge or review on this so the dependents can flow. Happy to rebase anything needed.

— Yzgaming005

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS PR: 1-10 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants