- 
                Notifications
    You must be signed in to change notification settings 
- Fork 35
Add support for ax.locator_params() #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            sjsmith757
  wants to merge
  3
  commits into
  SciTools:main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
sjsmith757:master
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
      
        
          +60
        
        
          −0
        
        
          
        
      
    
  
  
     Open
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            3 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      
    File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
|  | @@ -185,5 +185,50 @@ def test_NetCDFTimeDateLocator_date_unit_warning(): | |
| NetCDFTimeDateLocator(5, "360_day", "days since 2000-01-01") | ||
|  | ||
|  | ||
| class Test_set_params(unittest.TestCase): | ||
| def setUp(self): | ||
| # list of maxs to trigger different resolutions | ||
| self.vmax_list = [0.0003, 0.02, 1, 30, 365, 5000] | ||
| self.params = {"nbins": 10, "min_n_ticks": 4} | ||
|  | ||
| def check(self, max_n_ticks, **kwargs): | ||
| # Create an instance of your class | ||
| locator = NetCDFTimeDateLocator( | ||
| max_n_ticks=max_n_ticks, calendar="gregorian" | ||
| ) | ||
| # Call the set_params method | ||
| locator.set_params(**kwargs) | ||
| return locator | ||
|  | ||
| def test_set_params(self): | ||
| for key, value in self.params.items(): | ||
| for vmax in self.vmax_list: | ||
| locator = self.check(3, **{key: value}) | ||
| ticks = locator.tick_values(0, vmax) | ||
| # Assert that the expected values are set and returned | ||
| if key == "nbins": | ||
| # not more than max + 1 | ||
| self.assertFalse(ticks.size > value + 1) | ||
| # make sure number of ticks increased from initial | ||
| self.assertTrue(ticks.size > 4) | ||
| elif key == "min_n_ticks": | ||
| # not less than min | ||
| self.assertFalse(ticks.size < value) | ||
| else: | ||
| raise ValueError( | ||
| "tests on parameters other than nbins and min_n_ticks are not" | ||
| " yet implemented" | ||
| ) | ||
|  | ||
| # Add more assertions to test the behavior of the method | ||
| # For example, you can assert that the internal state of the locator is updated correctly | ||
| self.assertEqual( | ||
| getattr(locator._max_n_locator_days, f"_{key}"), value | ||
| ) | ||
| self.assertEqual( | ||
| getattr(locator._max_n_locator, f"_{key}"), value | ||
| ) | ||
| 
      Comment on lines
    
      +223
     to 
      +230
    
   There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I could go either way on including these checks.  They are a nice explicit way of checking that the  | ||
|  | ||
|  | ||
| if __name__ == "__main__": | ||
| unittest.main() | ||
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.