-
Notifications
You must be signed in to change notification settings - Fork 296
Stricter array summary in CML output #6743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Add `checksum` to _DimensionalMetadata xml. - New `masked_count` attr added to cube and _DimensionalMetadata xml.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ukmo-ccbunney Lookin' good.
Just some initial comments to consider 👍
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6743 +/- ##
==========================================
- Coverage 90.29% 89.99% -0.30%
==========================================
Files 91 91
Lines 24475 24608 +133
Branches 4571 4601 +30
==========================================
+ Hits 22100 22147 +47
- Misses 1607 1687 +80
- Partials 768 774 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
A real-life case of CML protecting us, if you were interested: |
The latest commit 029867f changes the behaviour of the If you are happy with the approach, then I will update the tests accordingly. |
the setting if the keyword is non-None. This allows for nested context managers without loosing previous settings.
Commit 31cea83 removes JSON data stats files and puts the results in the CML instead via a |
🚀 Pull Request
Closes: #6244
Description
Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: