Skip to content

Conversation

ukmo-ccbunney
Copy link
Contributor

🚀 Pull Request

Closes: #6244

Description


Consult Iris pull request check list


Add any of the below labels to trigger actions on this PR:

  • benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

 - Add `checksum` to _DimensionalMetadata xml.
 - New `masked_count` attr added to cube and _DimensionalMetadata xml.
@ukmo-ccbunney ukmo-ccbunney requested a review from bjlittle October 9, 2025 13:07
@bjlittle bjlittle moved this to 🚀 In Progress in 🦌 Iris 3.14 Oct 9, 2025
Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ukmo-ccbunney Lookin' good.

Just some initial comments to consider 👍

@github-project-automation github-project-automation bot moved this from 🚀 In Progress to 👀 In Review in 🦌 Iris 3.14 Oct 9, 2025
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

❌ Patch coverage is 41.29032% with 91 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.99%. Comparing base (0a881ee) to head (31cea83).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
lib/iris/util.py 39.28% 50 Missing and 1 partial ⚠️
lib/iris/coords.py 16.27% 31 Missing and 5 partials ⚠️
lib/iris/cube.py 85.71% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6743      +/-   ##
==========================================
- Coverage   90.29%   89.99%   -0.30%     
==========================================
  Files          91       91              
  Lines       24475    24608     +133     
  Branches     4571     4601      +30     
==========================================
+ Hits        22100    22147      +47     
- Misses       1607     1687      +80     
- Partials      768      774       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@trexfeathers
Copy link
Contributor

trexfeathers commented Oct 14, 2025

A real-life case of CML protecting us, if you were interested:

SciTools/iris-grib#708

@ukmo-ccbunney
Copy link
Contributor Author

The latest commit 029867f changes the behaviour of the assert_CML function to generate data statistics in the CML rather than in a separate JSON file. This will make all the tests that call assert_CML(approx_data=True) to fail.

If you are happy with the approach, then I will update the tests accordingly.

the setting if the keyword is non-None. This allows for nested
context managers without loosing previous settings.
@ukmo-ccbunney
Copy link
Contributor Author

Commit 31cea83 removes JSON data stats files and puts the results in the CML instead via a stats sub element.
Note, this implies loading the data which removes the state attribute (much like calculating the checksum does).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status
Status: 👀 In Review

Development

Successfully merging this pull request may close these issues.

Rationalise CML Testing

3 participants