Skip to content

Make benchmark result comparison machine-specific #6550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make benchmark result comparison machine-specific #6550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion benchmarks/bm_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,11 +140,21 @@ def _asv_compare(
) -> None:
"""Run through a list of commits comparing each one to the next."""
commits = tuple(commit[:8] for commit in commits)

machine_script = [
"from asv.machine import Machine",
"print(Machine.get_unique_machine_name())",
]
machine_name = _subprocess_runner_capture(
["python", "-c", ";".join(machine_script)]
)

for i in range(len(commits) - 1):
before = commits[i]
after = commits[i + 1]
asv_command = shlex.split(
f"compare {before} {after} --factor={COMPARE_FACTOR} --split"
f"compare {before} {after} "
f"--machine {machine_name} --factor={COMPARE_FACTOR} --split"
)

comparison = _subprocess_runner_capture(asv_command, asv=True)
Expand Down
5 changes: 5 additions & 0 deletions docs/src/whatsnew/latest.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,11 @@ This document explains the changes made to Iris for this release
benchmark data generation, showing developers the root problem at-a-glance
without needing local replication. (:pull:`6524`)

#. `@trexfeathers`_ fixed benchmark result comparison to inspect the results
for the current machine only. This is useful for setups where a single
home-space is shared between multiple machines, as with some virtual desktop
arrangements. (:pull:`6550`)


.. comment
Whatsnew author names (@github name) in alphabetical order. Note that,
Expand Down
Loading