Redirect ALL un-loadable NetCDF objects to LOAD_PROBLEMS
#6465
+834
−284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6465 +/- ##
==========================================
+ Coverage 89.80% 89.83% +0.02%
==========================================
Files 90 90
Lines 23755 23829 +74
Branches 4418 4429 +11
==========================================
+ Hits 21334 21407 +73
Misses 1672 1672
- Partials 749 750 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
trexfeathers
commented
May 16, 2025
Comment on lines
+490
to
+491
| # TODO: is it acceptable to use dataclass instead of NamedTuple purely | ||
| # because the docs render cleaner?! |
trexfeathers
commented
May 23, 2025
| @@ -48,7 +48,7 @@ | |||
| <dimCoord id="62e940e0" points="[10, 20, 30]" shape="(3,)" standard_name="longitude" units="Unit('degrees')" value_type="int32" var_name="lon"/> | |||
| </coord> | |||
| <coord datadims="[0]"> | |||
| <auxCoord id="cb784457" points="[ 1, 100, 3]" shape="(3,)" standard_name="time" units="Unit('hours since 1970-01-01 00:00:00', calendar='standard')" value_type="int32" var_name="time3"/> | |||
| <auxCoord id="cb784457" points="[ 1, --, 3]" shape="(3,)" standard_name="time" units="Unit('hours since 1970-01-01 00:00:00', calendar='standard')" value_type="int32" var_name="time3"/> | |||
There was a problem hiding this comment.
This may look like I'm just changing the test to suit me! But I believe my changes have actually improved how Iris works. Our previous graceful fallback on to AuxCoord involved using the DimCoord arguments for AuxCoord creation - so no masking - whereas we are now fully retrying the whole process if DimCoord fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Closes #6319
Objects
LoadProblems.Problem.handledflagLoadProblems.Problem.destinationattribute, for maximum contextRefactor existing changes to capture objects being added to non-Cubeobjects tooConsult Iris pull request check list
Add any of the below labels to trigger actions on this PR: