-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preparations for the new v5 SciTools CLA #2306
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
ping @SciTools/cartopy-devs |
Does #2285 need to be merged before this? |
greglucas
approved these changes
Dec 22, 2023
dopplershift
approved these changes
Dec 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me. I'll leave this open for others to review.
bjlittle
approved these changes
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Reference the upcoming new SciTools Contributor Licence Agreement (v5), which is being implemented to comply with legal advice from the UK Met Office - see #1919 (comment) .
I have chosen to no longer link to scitools.org.uk, since the new CLA is designed to be 'self-describing' without needing other exposition, hence the new Summary section at the top.
This is has been set up - via CLA Assistant - in most SciTools repositories on
2023-12-22
. Cartopy has been exempted to allow time for people to see and discuss. We could add further documentation, and even altering the CLA's summary text would be OK at this point because very few people would need to re-sign.Implications
All pull request authors will be automatically asked to sign the CLA as part of the continuous integration checks. An example of such a check is here: SciTools/iris-esmf-regrid#239 (comment) .
The intention is to apply a branch protection rule that prevents merges to
main
unless all commit authors have signed the CLA, achieved by checking for a ✔ from this CI check.