Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update arraymancer dependency, remove toHashSet #67

Merged
merged 1 commit into from
May 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion datamancer.nimble
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ srcDir = "src"

requires "nim >= 1.2.0"
requires "https://github.com/Vindaar/seqmath >= 0.2.1"
requires "arraymancer >= 0.7.28"
requires "arraymancer >= 0.7.30"

task test, "Run standard tests":
exec "nim c -r tests/testDf.nim"
Expand Down
5 changes: 0 additions & 5 deletions src/datamancer/dataframe.nim
Original file line number Diff line number Diff line change
Expand Up @@ -788,7 +788,7 @@
doAssert df.len == 3
doAssert df["x", int] == [1, 3, 5].toTensor
doAssert df["y", int] == [2, 5, 10].toTensor
{.warning: "Using `add` to add rows to a DF individually is very slow. Be " &

Check warning on line 791 in src/datamancer/dataframe.nim

View workflow job for this annotation

GitHub Actions / linux (version-2-0)

Using `add` to add rows to a DF individually is very slow. Be sure to only add very few rows using this proc! [User]

Check warning on line 791 in src/datamancer/dataframe.nim

View workflow job for this annotation

GitHub Actions / linux (devel)

Using `add` to add rows to a DF individually is very slow. Be sure to only add very few rows using this proc! [User]

Check warning on line 791 in src/datamancer/dataframe.nim

View workflow job for this annotation

GitHub Actions / linux (version-1-6)

Using `add` to add rows to a DF individually is very slow. Be sure to only add very few rows using this proc! [User]

Check warning on line 791 in src/datamancer/dataframe.nim

View workflow job for this annotation

GitHub Actions / windows (version-1-6)

Using `add` to add rows to a DF individually is very slow. Be sure to only add very few rows using this proc! [User]

Check warning on line 791 in src/datamancer/dataframe.nim

View workflow job for this annotation

GitHub Actions / windows (version-2-0)

Using `add` to add rows to a DF individually is very slow. Be sure to only add very few rows using this proc! [User]

Check warning on line 791 in src/datamancer/dataframe.nim

View workflow job for this annotation

GitHub Actions / windows (devel)

Using `add` to add rows to a DF individually is very slow. Be sure to only add very few rows using this proc! [User]

Check warning on line 791 in src/datamancer/dataframe.nim

View workflow job for this annotation

GitHub Actions / linux (version-1-6)

Using `add` to add rows to a DF individually is very slow. Be sure to only add very few rows using this proc! [User]

Check warning on line 791 in src/datamancer/dataframe.nim

View workflow job for this annotation

GitHub Actions / linux (devel)

Using `add` to add rows to a DF individually is very slow. Be sure to only add very few rows using this proc! [User]

Check warning on line 791 in src/datamancer/dataframe.nim

View workflow job for this annotation

GitHub Actions / linux (version-2-0)

Using `add` to add rows to a DF individually is very slow. Be sure to only add very few rows using this proc! [User]

Check warning on line 791 in src/datamancer/dataframe.nim

View workflow job for this annotation

GitHub Actions / windows (version-1-6)

Using `add` to add rows to a DF individually is very slow. Be sure to only add very few rows using this proc! [User]

Check warning on line 791 in src/datamancer/dataframe.nim

View workflow job for this annotation

GitHub Actions / windows (devel)

Using `add` to add rows to a DF individually is very slow. Be sure to only add very few rows using this proc! [User]

Check warning on line 791 in src/datamancer/dataframe.nim

View workflow job for this annotation

GitHub Actions / windows (version-2-0)

Using `add` to add rows to a DF individually is very slow. Be sure to only add very few rows using this proc! [User]
"sure to only add very few rows using this proc!".}
if args.tupleLen != df.ncols and df.ncols != 0:
raise newException(ValueError, "Input tuple `args` length must be equal " &
Expand Down Expand Up @@ -2003,11 +2003,6 @@
for i in 2 ..< dfs.len:
result = result.innerJoin(dfs[i], by)

proc toHashSet*[T](t: Tensor[T]): HashSet[T] =
## Internal helper to convert a tensor to a `HashSet`
for el in t:
result.incl el

proc group_by*[C: ColumnLike](df: DataTable[C], by: varargs[string], add = false): auto =
## Returns a grouped data frame grouped by all unique keys in `by`.
##
Expand Down
Loading