Remove MacroTools.jl dependency #296
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR eliminates the dependency on MacroTools.jl by replacing all @forward macro usage with explicit method forwarding. ## Changes Made 1. **Removed MacroTools import** from `src/SciMLOperators.jl` 2. **Replaced @forward macro usage** with explicit method definitions in: - `src/basic.jl`: InvertedOperator forwarding methods - `src/matrix.jl`: MatrixOperator and InvertibleOperator forwarding methods - `src/left.jl`: AdjointOperator/TransposedOperator forwarding methods (generated via @eval) 3. **Removed MacroTools from Project.toml** dependencies and compat sections 4. **Formatted code** using JuliaFormatter with SciMLStyle ## Testing All tests pass successfully after the changes. The explicit method forwarding provides the exact same functionality as the previous @forward macro usage. ## Benefits - Removes an external dependency - Makes the code more explicit and easier to understand - Reduces compilation overhead from macro expansion - Maintains 100% backward compatibility 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR eliminates the dependency on MacroTools.jl by replacing all
@forwardmacro usage with explicit method forwarding.Changes Made
src/SciMLOperators.jlsrc/basic.jl: InvertedOperator forwarding methodssrc/matrix.jl: MatrixOperator and InvertibleOperator forwarding methodssrc/left.jl: AdjointOperator/TransposedOperator forwarding methods (generated via @eval)Testing
All tests pass successfully after the changes. The explicit method forwarding provides the exact same functionality as the previous @forward macro usage.
Benefits
🤖 Generated with Claude Code