Skip to content

Conversation

gaurav-arya
Copy link
Member

@gaurav-arya gaurav-arya commented Jul 21, 2023

TODO:

  • make sure sparse matrices correctly handled (don't drop zeros)

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #213 (508da8c) into master (dd8fc48) will decrease coverage by 0.17%.
The diff coverage is 53.44%.

@@            Coverage Diff             @@
##           master     #213      +/-   ##
==========================================
- Coverage   70.24%   70.07%   -0.17%     
==========================================
  Files          10       10              
  Lines        1583     1641      +58     
==========================================
+ Hits         1112     1150      +38     
- Misses        471      491      +20     
Impacted Files Coverage Δ
src/SciMLOperators.jl 100.00% <ø> (ø)
src/basic.jl 70.78% <50.00%> (-0.95%) ⬇️
src/interface.jl 52.25% <62.50%> (+0.79%) ⬆️
src/matrix.jl 67.85% <100.00%> (+0.33%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vpuri3
Copy link
Member

vpuri3 commented Jul 21, 2023

can you explain what's going on?

@gaurav-arya
Copy link
Member Author

If L is a lazy operator, we might want to do A = convert(AbstractMatrix, L) because cerrtain operations might be faster with the matrix. But written like I just did, A loses the updating behaviour, whereas ConcretizedOperator does not. Similar to _concrete_form for WOperator's.

This PR is still WIP though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants