Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow initialization of null integrators #2228

Closed

Conversation

AayushSabharwal
Copy link
Member

Requires

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@ChrisRackauckas
Copy link
Member

What's a case that needs this?

@AayushSabharwal
Copy link
Member Author

This was part of the rework that allows parameters to be unknowns in the initialization system. That bit is on hold for the time being, pending the discussion in SciML/ModelingToolkit.jl#2665

@ChrisRackauckas
Copy link
Member

Don't you just need to add the initializationprob call up here? https://github.com/SciML/DiffEqBase.jl/blob/master/src/solve.jl#L678

@AayushSabharwal
Copy link
Member Author

Hmm yeah that does look better. I'll try that, thanks!

@AayushSabharwal
Copy link
Member Author

Superseded by #2314

@AayushSabharwal AayushSabharwal deleted the as/param-initprob branch August 6, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants