Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the new algorithm
SharpFineRKN6
mentioned in #677. The Algorithm works on general second order differential equations.The convergence plots below show a convergence which does not match the convergence rate mentioned in the paper and a large error.
Convergence plots harmonic Oscillator:
Convergence plots damped Oscillator:
Unfortunately the scan quality of the paper (https://doi.org/10.1016/0377-0427(92)90081-8) leaves some coefficients unrecognizable (mainly
abar84
,a51
,a71
,a71
anda82
on page 289). With the order conditions (6), (7) and (21) mentioned in the paper, I identified the correct coefficients which can be found in the src/tableaus/rkn_tableaus.jl file. However that did not resolve the issue with the poor convergence and large error. Further investigation shows that order condition (10) mentioned in the paper is not satisfied. Since (7) and (9) are satisfied the error has to be in one ore more of the following coefficients:a43
,a53
,a54
,a63
,a64
,a65
,a73
,a74
,a75
,a76
. I double checked the coefficients imported in src/tableaus/rkn_tableaus.jl. Everything is correct here. It is possible that I overlooked something and/or there is a typo in the paper.The error could also be in the perform step function (implemented in src/perform_step/rkn_perform_step.jl). I double checked everything here too nut could not find a mistake.
Help is appreciated!
@ranocha