Skip to content

Copy parameter object before setting in subset_tunables #3922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 26, 2025
Merged

Copy parameter object before setting in subset_tunables #3922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2b24c04
chore: copy parameters from sys
DhairyaLGandhi Sep 11, 2025
fc62ff1
test: check length of original system tunables
DhairyaLGandhi Sep 17, 2025
a4c6ad5
test: improve test checking
DhairyaLGandhi Sep 18, 2025
ac5ec9c
test: typo
DhairyaLGandhi Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/parameters.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ function subset_tunables(sys, new_tunables)
Note that array parameters can only be set as tunable or non-tunable, not partially tunable. They should be specified in the un-scalarized form.
"""))
end
cur_ps = get_ps(sys)
cur_ps = copy(get_ps(sys))
const_ps = toconstant.(diff_params)

for (idx, p) in enumerate(cur_ps)
Expand Down
3 changes: 3 additions & 0 deletions test/parameter_dependencies.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@ end
sys = mtkcompile(pendulum_sys)

new_tunables = [L, b]
old_tunables = copy(ModelingToolkit.tunable_parameters(sys, ModelingToolkit.parameters(sys)))
sys2 = ModelingToolkit.subset_tunables(sys, new_tunables)
sys2_tunables = ModelingToolkit.tunable_parameters(sys2, ModelingToolkit.parameters(sys2))
@test length(sys2_tunables) == 2
Expand All @@ -198,6 +199,8 @@ end
@test_throws ArgumentError ModelingToolkit.subset_tunables(sys_incomplete, new_tunables)
sys_nonsplit = mtkcompile(pendulum_sys; split = false)
@test_throws ArgumentError ModelingToolkit.subset_tunables(sys_nonsplit, new_tunables)

@test length(ModelingToolkit.tunable_parameters(sys, ModelingToolkit.parameters(sys))) == length(old_tunables)
end

struct CallableFoo
Expand Down
Loading