-
-
Notifications
You must be signed in to change notification settings - Fork 217
MTKModel: Provision to specify the type of System
#3526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
System
e2a95f7
to
85b2bca
Compare
Instead of this, can we just target System? Is it smart enough to handle DiscreteSystem at this point @AayushSabharwal |
I found only one method of |
No, |
The test failures on Julia-Pre version are unrelated to this PR. I've leveraged This PR is ready for review (and to decide whether we want to add |
Can this be merged? |
@AayushSabharwal is that failing interface tests or just needs to rebase? |
Looks like it just needs to rebase |
System is an exported function. And now it is used to build ODESystem by default
Type of the system can be specified via:
By default it is ODESystem.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Closes #3498