Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Remove RenovateBot #329

Merged
merged 2 commits into from
Jan 8, 2024
Merged

ci: Remove RenovateBot #329

merged 2 commits into from
Jan 8, 2024

Conversation

johannes-riecken
Copy link
Contributor

@johannes-riecken johannes-riecken commented Dec 27, 2023

We'd prefer to use Github's integrated Dependabot for version upodates and security updates, as that's more widely used for open source software.

Adding Dependabot's version updating capabilities is done in a separate PR.

Part of #312.

We'd prefer to use Github's integrated Dependabot for version upodates
and security updates, as that's more widely used for open source
software.

Adding Dependabot's version updating capabilities is done in a separate
PR.
johannes-riecken added a commit that referenced this pull request Dec 27, 2023
There's a separate PR #329 to remove Renovate, so that we don't get
duplicate dependency upgrade PRs.
Copy link
Contributor

@zalgonoise zalgonoise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarvinJWendt
Copy link
Member

Since renovate is not running as a GitHub Action / Workflow, I think it might be installed as an app. If that's the case, I am not sure if removing the config will completely disable the bot, or if it will fall back to a default config then. If it's enabled orga-wide we could disable it here with { "enabled": false } in the config, or maybe @patrick246 can uninstall the App / revoke permissions for this repository.

@patrick246 could you check, if renovate is installed as an app?

@MarvinJWendt
Copy link
Member

MarvinJWendt commented Dec 30, 2023

Updated the PR, so that the CI doesn't fail on semgrep.

PS: We also need to close all RenovateBot PRs after this is merged, so that Dependabot can take over from here.

@patrick246
Copy link
Member

Yes, renovate was installed as an App, I have revoked permissions on this repository

@MarvinJWendt MarvinJWendt merged commit 59e833d into main Jan 8, 2024
3 checks passed
@MarvinJWendt MarvinJWendt deleted the chore/remove-renovatebot branch January 8, 2024 08:45
MarvinJWendt added a commit that referenced this pull request Jan 8, 2024
There's a separate PR #329 to remove Renovate, so that we don't get
duplicate dependency upgrade PRs.

Co-authored-by: Marvin Wendt <[email protected]>
@MarvinJWendt MarvinJWendt changed the title fix(ci): Remove RenovateBot ci: Remove RenovateBot Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants