Repository navigation
bump dependencies - #235
Merged
Merged
Conversation
github-project-automation
Bot
moved this to In Progress
in MyHeart Counts Project Planning
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
github-project-automation
Bot
moved this from In Progress
to Done
in MyHeart Counts Project Planning
lukaskollmer
added a commit
that referenced
this pull request
Nov 5, 2026
#235 replaced the account sheet's logout button with a "Log Out" button and alert, so testLogout could no longer find "Logout". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lukaskollmer
added a commit
that referenced
this pull request
Nov 5, 2026
#235 moved these actions into a single `alert(_:item:)`. AsyncButton runs its action in a `.task`, and the `item:` alert removes the button as soon as tapping it dismisses the alert, so neither action ever ran. testLogout caught this: the alert closed, but the account sheet stayed open and the user stayed signed in. Give each action its own `isPresented:` alert, which is what Grove's AccountOverview does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
♻️ Current situation & Problem
deps are partially outdated
⚙️ Release Notes
📚 Documentation
n/a
✅ Testing
n/a
Code of Conduct & Contributing Guidelines
By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: