Repository navigation
ui tests: redistribute from 4 into 6 shards - #234
Merged
Merged
Conversation
Use all six self-hosted runners. Shards are balanced on timings from runs since 2026-11-02. A failing test reruns its whole shard, so TaskHandlingTests sits in a short shard to keep a testECG retry off the critical path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
github-project-automation
Bot
moved this to In Progress
in MyHeart Counts Project Planning
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
lukaskollmer
changed the title
#235 replaced the account sheet's logout button with a "Log Out" button and alert, so testLogout could no longer find "Logout". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
#235 moved these actions into a single `alert(_:item:)`. AsyncButton runs its action in a `.task`, and the `item:` alert removes the button as soon as tapping it dismisses the alert, so neither action ever ran. testLogout caught this: the alert closed, but the account sheet stayed open and the user stayed signed in. Give each action its own `isPresented:` alert, which is what Grove's AccountOverview does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The AsyncButton never fit here: the alert dismisses itself on tap, so the button can't show progress, and its task is tied to the alert's content. Use a plain Button that starts a Task owned by the sheet, so the action outlives the alert and a single `item:` alert covers both actions again. Also disable the account section while an action is running, since closing the alert would otherwise re-enable its buttons. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
github-project-automation
Bot
moved this from In Progress
to Done
in MyHeart Counts Project Planning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
♻️ Current situation & Problem
CI now has 6 self-hosted runners, but the UI tests are split into only 4 shards. A failing test also reruns its whole shard, and
testECGcurrently fails its first attempt (#233), so one shard takes about 31 min instead of 16.⚙️ Release Notes
Before merging: remove these required checks from the
Mainruleset. The shard names changed, so they will never report:App UI Tests (Run; Consent Major, Other, Timed Walk, Regression)App UI Tests (Run; Consent Minor, Onboarding, Basic Usage)App UI Tests (Run; Consent Review and Patch, Prompted Actions, Tasks)App UI Tests (Run; Consent Skip, Health Dashboard, Scheduled)App UI Tests / Test using xcodebuild or run fastlanestays required and still fails if any shard fails.📚 Documentation
Shards are balanced on median test times and listed longest first:
Shard 06 is short on purpose: it contains
testECG, so a whole-shard retry takes 9.4 min and finishes before the other shards.Per-run data puts the slowest shard at 12–13 min, down from about 31 min. UI tests from start to finish should drop from about 40 min to about 22–23 min. The whole CI run should drop from about 42 min to about 34 min, limited by
Utils Unit Tests (Linux Release).Decisions:
Mainruleset change is made manually before merging.✅ Testing
actionlintpasses onbuild-and-test.yml.validate-ui-test-shards.sh, which needs built test products. CI runs both on this PR.Code of Conduct & Contributing Guidelines
By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:
🤖 Generated with Claude Code