feat: Use ReadableStream instead of a stream of bytes #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // display | ||
| append_img_uri(uri); | ||
|
|
||
| // dowbloadable link |
|
note, this will require changes in UplinkWeb similar to the constellation example. |
dariusc93
commented
Dec 30, 2024
Flemmli97
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would use an AsyncIterator for handling rust streams, and in some situations they do work well but it can be a problem when it comes to handling streams for files as these would be chunks of data that is streamed. While an AsyncIterator could handle it, it may not be idiomatic to work with other functions without redundant workarounds. Additionally, in some cases, would require to buffer the data, which is not ideal for large sums of data.
This PR, while more of a PoC, would begin the process of using
ReadableStreamin place ofAsyncIterator, which should work best for different situations such as creating a blob to download files without the need to buffer them. In other situations, could probably be used in place ofAsyncIteratorfor events, however that would need discussions to determine if that might be suitable.