Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(update): update tests for manage members modal fix #648

Merged
merged 3 commits into from
Feb 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ui-automated-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ jobs:
uses: actions/checkout@v4
with:
repository: Satellite-im/Uplink
ref: fix-group-users-manage-modal

- name: Checkout testing directory πŸ”–
uses: actions/checkout@v4
Expand Down Expand Up @@ -145,6 +146,7 @@ jobs:
uses: actions/checkout@v4
with:
repository: Satellite-im/Uplink
ref: fix-group-users-manage-modal

- name: Checkout testing directory πŸ”–
uses: actions/checkout@v4
Expand Down
11 changes: 2 additions & 9 deletions tests/specs/reusable-accounts/10-group-chats-edit.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -122,13 +122,9 @@ export default async function groupChatEditTests() {
await manageMembers.typeOnSearchUserInput("ChatUserB");
await manageMembers.clickOnFirstRemoveButton();

/*
Skipping validation for bug opened
await manageMembers.validateNothingHereIsDisplayed();

// Close Manage Members modal
await chatsTopbar.exitManageMembers();
*/

await chatsSidebar.validateNoModalIsOpen();
await chatsTopbar.validateTopbarExists();

Expand Down Expand Up @@ -165,13 +161,10 @@ export default async function groupChatEditTests() {
await manageMembers.typeOnSearchUserInput("ChatUserB");
await manageMembers.clickOnFirstAddButton();

/*
Skipping validation for bug opened
await manageMembers.validateNothingHereIsDisplayed();

// Close Manage Members modal
await chatsTopbar.exitManageMembers();
*/

await chatsSidebar.validateNoModalIsOpen();
await chatsTopbar.validateTopbarExists();

Expand Down
14 changes: 7 additions & 7 deletions tests/specs/reusable-accounts/11-group-chats-sidebar.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -141,21 +141,20 @@ export default async function groupChatSidebarTests() {
await expect(topbarUserStatus).toHaveText("Members (1)");
});

it("Group Chat - Add Chat User B again to the group", async () => {
// Code will be fixed on https://github.com/Satellite-im/Uplink/pull/1886
xit("Group Chat - Add Chat User B again to the group", async () => {
// Go to Manage Members and then add again Chat User B to the group
await chatsTopbar.openManageMembers();
await manageMembers.validateManageMembersIsShown();
await manageMembers.clickOnAddMembers();
await manageMembers.typeOnSearchUserInput("ChatUserB");
await manageMembers.clickOnFirstAddButton();

/*
Skipping validation for bug opened
await manageMembers.validateNothingHereIsDisplayed();

// Close Manage Members and validate topbar contents has correct number of participants
await chatsTopbar.exitManageMembers();
*/

await chatsSidebar.validateNoModalIsOpen();
await chatsTopbar.validateTopbarExists();

Expand All @@ -164,7 +163,8 @@ export default async function groupChatSidebarTests() {
await expect(topbarUserStatus).toHaveText("Members (2)");
});

it("Group Chat - Ensure in remote side that user was added again to the group", async () => {
// Code will be fixed on https://github.com/Satellite-im/Uplink/pull/1886
xit("Group Chat - Ensure in remote side that user was added again to the group", async () => {
// Switch execution to User B and ensure that user was added again to the group
await activateSecondApplication();
await chatsSidebar.goToFiles();
Expand All @@ -180,7 +180,7 @@ export default async function groupChatSidebarTests() {
await expect(topbarUserName).toHaveText("X");
});

// Skipping test due to bug under investigation
// Code will be fixed on https://github.com/Satellite-im/Uplink/pull/1886
xit("Group Chat - Sidebar - Delete group", async () => {
// Switch execution to User A and delete the group
await activateFirstApplication();
Expand All @@ -191,7 +191,7 @@ export default async function groupChatSidebarTests() {
await chatsSidebar.validateSidebarChatIsNotDisplayed("X");
});

// Skipping test due to bug under investigation
// Code will be fixed on https://github.com/Satellite-im/Uplink/pull/1886
xit("Group Chat - Sidebar - Deleted group is not shown on remote side", async () => {
// Switch execution to remote user and ensure that group was removed on this side too
await activateSecondApplication();
Expand Down
Loading