Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(update): skip dark light toggle theme for windows copy assets #614

Merged
merged 1 commit into from
Jan 30, 2024
Merged

test(update): skip dark light toggle theme for windows copy assets #614

merged 1 commit into from
Jan 30, 2024

Conversation

luisecm
Copy link
Collaborator

@luisecm luisecm commented Jan 30, 2024

What this PR does 📖

  • UI Tests on Windows started to fail because the assets are not copied correctly on CI execution.
  • Skipping tests failing due to crash on missing themes files not copied over on Windows CI (short term solution)
  • Long term solution is that Windows CI will be modified to automate the installer process instead of manually grabbing assets files (which I will work on a different ticket)

Which issue(s) this PR fixes 🔨

  • Resolve #

Special notes for reviewers 🗒️

Additional comments 🎤

@luisecm luisecm merged commit 25c46a2 into dev Jan 30, 2024
4 of 5 checks passed
@luisecm luisecm deleted the luis/skip-clear-accent branch January 30, 2024 05:46
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2024 •
edited
Loading

UI Automated Tests execution is complete! You can find the test results report here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@luisecm