Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

screenobject(update): add new aria labels for settings and seed words #588

Merged
merged 6 commits into from
Jan 10, 2024

Conversation

luisecm
Copy link
Collaborator

@luisecm luisecm commented Jan 9, 2024

What this PR does πŸ“–

  • Add new aria labels for settings
  • Add new aria labels for recovery seed screens

Which issue(s) this PR fixes πŸ”¨

  • Resolve #

Special notes for reviewers πŸ—’οΈ

Additional comments 🎀

@luisecm luisecm added the Draft Draft PR just to see if it works on CI label Jan 9, 2024
@github-actions github-actions bot added Missing dev review Failed Automated Test The latest commit on this PR failed automation tests labels Jan 9, 2024
Copy link

github-actions bot commented Jan 10, 2024

UI Automated Test Results Summary for MacOS/Windows

485 tests   401 βœ…β€ƒβ€ƒ2h 20m 33s ⏱️
 40 suites   84 πŸ’€
  3 files      0 ❌

Results for commit 567c890.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 10, 2024

UI Automated Tests execution is complete! You can find the test results report here

@luisecm luisecm removed the Draft Draft PR just to see if it works on CI label Jan 10, 2024
@github-actions github-actions bot removed the Failed Automated Test The latest commit on this PR failed automation tests label Jan 10, 2024
@luisecm luisecm merged commit 03f6ca1 into dev Jan 10, 2024
2 of 3 checks passed
@luisecm luisecm deleted the luis/update-settings branch January 10, 2024 22:04
@github-actions github-actions bot added Failed Automated Test The latest commit on this PR failed automation tests and removed Missing dev review labels Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Failed Automated Test The latest commit on this PR failed automation tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant