Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(appium): refactor for chats and improve code readability #582

Merged
merged 4 commits into from
Jan 2, 2024

Conversation

luisecm
Copy link
Collaborator

@luisecm luisecm commented Dec 22, 2023

What this PR does 📖

  • Refactor to improve code readability by removing "firstUser" words on import and constants declarations (second part of removing user instances refactor)
  • Improve login with test user helper function to wait until pin user screen is gone to return
  • Applied changes for new chat message/message group screenobjects in chats tests
  • Attempt to unskip all chats tests

Which issue(s) this PR fixes 🔨

  • Resolve #

Special notes for reviewers 🗒️

Additional comments 🎤

@github-actions github-actions bot added Missing dev review Failed Automated Test The latest commit on this PR failed automation tests labels Dec 22, 2023
Copy link

github-actions bot commented Dec 22, 2023

UI Automated Test Results Summary for MacOS/Windows

483 tests   298 ✅  2h 14m 17s ⏱️
 40 suites  185 💤
  3 files      0 ❌

Results for commit 5a79d57.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 22, 2023

UI Automated Tests execution is complete! You can find the test results report here

@github-actions github-actions bot removed the Failed Automated Test The latest commit on this PR failed automation tests label Dec 22, 2023
@luisecm luisecm merged commit f258756 into dev Jan 2, 2024
9 checks passed
@luisecm luisecm deleted the luis/chats-remaining branch January 2, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant